| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | planstate_tree_walker |
| Date: | 2015-09-17 11:23:48 |
| Message-ID: | CA+TgmoZQ7o3k0NG-R3DE0Fhg5v5HAXWHtAs19bBf+HH-3sAViw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In my reviews of Amit's parallel sequential scan patches yesterday, I
complained that he was using planstate_tree_walker incorrectly, but I
failed to notice that this was because he'd defined
planstate_tree_walker incorrectly. This morning I figured that out.
:-)
Here is a patch that *just* introduces planstate_tree_walker and which
is hopefully correct. I stole the logic from ExplainPreScanNode,
which I also refactored to use the new walker instead of duplicating
the logic.
I'd like to go ahead and commit this if nobody sees a problem with it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| planstate-tree-walker.ptch | application/octet-stream | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2015-09-17 11:35:20 | LW_SHARED_MASK macro |
| Previous Message | Robert Haas | 2015-09-17 11:14:10 | Re: Parallel Seq Scan |