| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | José Luis Tallón <jltallon(at)adv-solutions(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [CommitFest App] Feature request -- review e-mail additions |
| Date: | 2016-04-04 22:15:13 |
| Message-ID: | CA+TgmoZPeQy+AY80kk3fYfZMCGGX-fDSyaHdKa0nr9qHAwdcbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 30, 2016 at 1:47 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> José Luis Tallón wrote:
>> Just wanted to suggest two minor mods to the review e-mails
>> auto-generated by the app:
>>
>> * Prepend a [review] tag to the e-mail subject
>> ... so that e-mails sent to -hackers will read " [HACKERS] [review]
>> <patch title goes here>"
>
> Changing the subject of an email causes Gmail to break the threads, so
> anything in that line should be discouraged. -1 from me. I would be
> happier if the subject of the submission email is kept intact, i.e. not
> use the patch title that was used in commitfest app but use the one in
> the email. These often differ.
I entirely agree with Alvaro.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-04 22:16:51 | Re: So, can we stop supporting Windows native now? |
| Previous Message | Alvaro Herrera | 2016-04-04 21:55:03 | Re: dealing with extension dependencies that aren't quite 'e' |