Re: shift_sjis_2004 related autority files are remaining

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: shift_sjis_2004 related autority files are remaining
Date: 2017-06-22 17:45:34
Message-ID: CA+TgmoZLxf==07j_bg4-bQw6vrV9DioH3kt2nL1=fT9Ugstm3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 7, 2017 at 1:59 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Hi, I happned to notice that backend/utils/mb/Unicode directory
> contains two encoding authority files, which I believe are not to
> be there.
>
> euc-jis-2004-std.txt
> sjis-0213-2004-std.txt
>
> And what is more astonishing, make distclean didn't its work.
>
> | $ make distclean
> | rm -f
>
> The Makefile there is missing the defenition of TEXT.
>
> # Sorry for the bogus patch by me..
>
> The attached is the *first patch* that fixes distclean and adds
> the two files into GENERICTEXTS.
>
> =====
>
> I don't attach the *second* patch since it's too large for the
> trivality and can be made by the following steps.
>
> $ cd src/backend/utils/mb/Unicode
> $ git rm *.txt
> $ git commit

I think you are right about all of this, although I am not an expert
in this area.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-06-22 17:50:31 Re: possible self-deadlock window after bad ProcessStartupPacket
Previous Message Daniel Verite 2017-06-22 17:42:11 Re: PATCH: Batch/pipelining support for libpq