| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Fabrizio Mello <fabriziomello(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Store Extension Options |
| Date: | 2014-01-06 03:08:02 |
| Message-ID: | CA+TgmoZLe9Muwjz-5=RqXGwqq=4tMeJP0FB4Z6RnyG6+XBHRqQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 5, 2014 at 3:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Sat, Jan 4, 2014 at 1:00 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I would suggest addressing Robert's concern about lack of error checking
>>> by refusing to allow a custom reloption to be set unless the relevant
>>> extension is loaded and checks it. Unlike the postgresql.conf problem,
>>> I don't see any very good use-case for allowing an unchecked ALTER TABLE
>>> to occur.
>
>> How do you plan to resolve the associated dump/restore hazard?
>
> pg_dump creates extensions before tables, no? So what dump/restore
> hazard?
Creating the extension doesn't guarantee that the shared library will
always be loaded. If nothing else, think about partial restores.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-01-06 03:11:33 | Re: [ANNOUNCE] IMCS: In Memory Columnar Store for PostgreSQL |
| Previous Message | Robert Haas | 2014-01-06 03:06:46 | Re: dynamic shared memory and locks |