| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: Incorrect comment in get_partition_dispatch_recurse |
| Date: | 2018-05-16 14:51:38 |
| Message-ID: | CA+TgmoZLchgm2XoVBjTP+ZLtVPW5i6jk+AfwBKGdWu4Uxvfn1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 14, 2018 at 12:57 AM, David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> I noticed that a comment in get_partition_dispatch_recurse claims that:
>
> "it contains the
> * leaf partition's position in the global list *leaf_part_oids minus 1"
>
> The "minus 1" part is incorrect. It simply just stores the 0-based
> index of the item in the list. I was going to fix it by removing just
> that part, but instead, I ended up rewriting the whole thing.
I think that's clearer. Committed with a few tweaks that are
hopefully improvements.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-05-16 14:57:16 | Re: log_min_messages shows debug instead of debug2 |
| Previous Message | Tom Lane | 2018-05-16 14:42:40 | Re: index scan over composite type |