Re: PostgresNode::_update_pid using undefined variables in tap tests

On Thu, Dec 3, 2015 at 11:28 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> This does not impact the run, but it creates unwelcome warnings in the
> logs. This is actually caused by the following code in PostgresNode
> that uses an incorrect check to see if the file has been correctly
> opened or not:
> open my $pidfile, $self->data_dir . "/postmaster.pid";
> if (not defined $pidfile)
>
> One way to fix this is to use if(open(...)), a second way I know of is
> to check if the opened file handle matches tell($pidfile) == -1. The
> patch attached uses the first method to fix the issue.

My Perl-fu must be getting weak. What's wrong with the existing code?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company