| From: | Robert Haas <robertmhaas(at)gmail(dot)com> | 
|---|---|
| To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> | 
| Cc: | tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> | 
| Subject: | Re: "parallel= " information is not coming in pg_dumpall for create aggregate | 
| Date: | 2016-04-21 03:06:22 | 
| Message-ID: | CA+TgmoZKSWBsXuNph5evtpNrvN7cgD2Eu6yQ6qOx6OJsJ5O-Ow@mail.gmail.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
On Mon, Apr 18, 2016 at 10:47 AM, Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
>> I checked in PG 9.6 , if we create an aggregate function with saying -
>> parallel=safe/restricted/unsafe and then take
>> a pg_dumpall of the entire cluster , "parallel= " is missing from create
>> aggregate syntax
>>
>> Steps to reproduce -
>>
>> .)connect to psql terminal and create an aggregate function
>>
>> postgres=# CREATE AGGREGATE unsafe_sum100 (float8)
>> (
>>     stype = float8,
>>     sfunc = float8pl,
>>     mstype = float8,
>>     msfunc = float8pl,
>>     minvfunc = float8mi,
>>     parallel=safe);
>> CREATE AGGREGATE
>>
>> .)perform pg_dumpall against that cluster
>>
>> .)check the content of create aggregate unsafe_sum100 in the file
>>
>> "
>> -
>> -- Name: unsafe_sum100(double precision); Type: AGGREGATE; Schema: public;
>> Owner: centos
>> --
>>
>> CREATE AGGREGATE unsafe_sum100(double precision) (
>>     SFUNC = float8pl,
>>     STYPE = double precision,
>>     MSFUNC = float8pl,
>>     MINVFUNC = float8mi,
>>     MSTYPE = double precision
>> );
>>
>> "
>
> You're correct... try the attached patch to fix it.
Nice catch, Tushar. Thanks for the patch, Fabrízio. Committed.
-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-21 03:07:41 | Re: Fix of doc for synchronous_standby_names. | 
| Previous Message | Kyotaro HORIGUCHI | 2016-04-21 02:56:40 | Re: pg_stat_activity crashes |