Re: allow_system_table_mods and DROP RULE

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: allow_system_table_mods and DROP RULE
Date: 2019-12-18 15:53:16
Message-ID: CA+TgmoZHmkrs4KZKHDtKbSbjXnjVG_TgDGK3d0GmKPRqg-PwJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 18, 2019 at 3:56 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> As a curious omission, DROP RULE does not check allow_system_table_mods.
> Creating and renaming a rule does, and also creating, renaming, and
> dropping a trigger does. The impact of this is probably nil in
> practice, but for consistency we should probably add that. The patch is
> pretty simple.

+1. LGTM.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2019-12-18 15:56:41 Re: Request to be allotted a project or a feature in pipeline
Previous Message Robert Haas 2019-12-18 15:48:09 Re: Request to be allotted a project or a feature in pipeline