Re: pg_amcheck contrib application

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_amcheck contrib application
Date: 2021-03-11 21:59:00
Message-ID: CA+TgmoZGk-mmV1xz=qOcxQ5fGtdK0_HVB2c8pVDUbMSaK8dM9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 11, 2021 at 11:09 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> An alternate possibility would be to say that there should only ever
> be EITHER a bare command-line argument OR options that require
> querying for a list of databases OR neither BUT NOT both. Then it's
> simple:
>
> 0. If you have both options which require querying for a list of
> databases and also a bare database name, error and die.
> 1. As above.
> 2. As above except the only possibility is now increasing the list of
> target databases from length 0 to length 1.
> 3. As above.

Here's a proposed incremental patch, applying on top of your last
version, that describes the above behavior, plus makes a lot of other
changes to the documentation that seemed like good ideas to me. Your
mileage may vary, but I think this version is substantially more
concise than what you have while basically containing the same
information.

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
doc-hacking.patch application/octet-stream 25.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-03-11 22:02:34 Re: cursor sensitivity misunderstanding
Previous Message Justin Pryzby 2021-03-11 21:24:05 Re: [HACKERS] Custom compression methods