Re: Patch: add --if-exists to pg_recvlogical

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Rosser Schwarz <rosser(dot)schwarz(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: add --if-exists to pg_recvlogical
Date: 2017-08-25 19:34:37
Message-ID: CA+TgmoZ98U2UddPo+zqnGOf=jL_0crZcSph6cfAgQdF70-3BGw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 21, 2017 at 3:04 PM, Rosser Schwarz
<rosser(dot)schwarz(at)gmail(dot)com> wrote:
> While doing some scripting around pg_recvlogical at $work, I found a need
> for $subject. Attached, find a patch to that effect.
>
> I tried simply to mirror the logic used elsewhere. I don't think there's
> anything controversial here, but welcome any comments or suggestions.
>
> This applies and builds successfully against master, and behaves as designed
> (i.e., dropping or trying to stream from a nonexistent slot exits cleanly).
> It doesn't affect any other behavior I could observe.
>
> If accepted, this will likely need a pgindent run upon merging; I had to
> give up on the rabbit hole of getting that working locally.

Please add this to commitfest.postgresql.org

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-08-25 19:37:31 Release plans: near-term update releases, and 10.0
Previous Message Robert Haas 2017-08-25 19:32:25 Re: Crash on promotion when recovery.conf is renamed