Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Christian Ullrich <chris(at)chrullrich(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013
Date: 2016-12-02 14:51:49
Message-ID: CA+TgmoZ7OXUcJ8J=YCOTfNnPKsvhhV+h0Ord2W2GJAhso_QnAw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Nov 30, 2016 at 2:56 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Nov 29, 2016 at 08:45:13PM +0100, Christian Ullrich wrote:
>> * Michael Paquier wrote:
>>
>> > On Wed, Nov 16, 2016 at 12:45 PM, Christian Ullrich
>> > <chris(at)chrullrich(dot)net> wrote:
>> >> I also did a debug build with 1+2+4 that came in at 84 μs/iteration.
>> >
>> > Moved to next CF. Christian, perhaps this patch should have an extra
>> > round of reviews?
>>
>> It is significantly different from the last version, so yes, of course.
>
> Patches 0001 (Cosmetic fixes), 0002 (Remove unnecessary CloseHandle)
> and 0003 (support for debug CRTs) look in good shape to me. 0004 (Fix
> load race) is 0002 from the previous set, and this change makes sense
> in itself.

0001 looks fine insofar as it makes things consistent regarding 0 vs.
NULL, but the whitespace changes will be reverted by pgindent. (I
just tested.)

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-12-02 16:37:08 pgsql: Add a crude facility for dealing with relative pointers.
Previous Message Robert Haas 2016-12-02 14:01:29 pgsql: Clarify that pg_stat_activity.query has a length limit.

Browse pgsql-hackers by date

  From Date Subject
Next Message Rahila Syed 2016-12-02 14:54:28 Re: Improvements in psql hooks for variables
Previous Message Vladimir Rusinov 2016-12-02 14:33:19 Re: s/xlog/wal/ in tools and function names?