From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minor improvements in alter_table.sgml |
Date: | 2014-04-28 14:12:25 |
Message-ID: | CA+TgmoZ5pipR-1YpojK1subDmBWcLHV0-AOYp1sVTxcNMwhVEg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 23, 2014 at 3:46 AM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> (2014/04/15 15:27), Etsuro Fujita wrote:
>> (2014/04/14 23:53), Robert Haas wrote:
>>>
>>> On Fri, Apr 11, 2014 at 5:00 AM, Etsuro Fujita
>>> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>>
>>>> Attached is an updated version of the patch.
>
>
>>> I think the other changes deserve to be considered separately, and in
>>> particular I'm still not sure it's a good idea to document both OF
>>> type_name and type_name.
>
>
> I've agreed on that point, but I think apart from the others, the trivial
> typo should be corrected. Patch attached (doc-altertable-typo.patch).
>
> I noticed the description of index_name should also be corrected, because it
> is currently used not only in CLUSTER ON, but in ADD
> table_constraint_using_index. (It will also be used in REPLICA IDENTITY in
> 9.4.) Patch attached (doc-altertable-indexname.patch).
Agreed. Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-04-28 14:13:19 | Re: Decrease MAX_BACKENDS to 2^16 |
Previous Message | Heikki Linnakangas | 2014-04-28 14:06:10 | Re: includedir_internal headers are not self-contained |