| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem with pg_upgrade's directory write check on Windows |
| Date: | 2011-07-25 17:57:25 |
| Message-ID: | CA+TgmoZ3ZeM8mnsW9K1P2MW6O+TS=BzVM1EafJNkDH_46_D2HQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jul 24, 2011 at 5:27 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Alvaro Herrera wrote:
>> Excerpts from Bruce Momjian's message of dom jul 24 01:46:08 -0400 2011:
>> > Robert Haas wrote:
>>
>> > > > Should I fix this in pg_upgrade 9.1 for Windows or just in 9.2? ?The
>> > > > check works fine on non-Windows.
>> > >
>> > > Seems worth back-patching to me.
>> >
>> > Attached patch applied and backpatched to 9.1. I was able to test both
>> > code paths on my BSD machine by modifying the ifdefs. I will have
>> > EnterpriseDB do further testing.
>>
>> Err, why not 9.0?
>
> The check did not exist in 9.0 -- I mentioned that in the commit
> message. I could add the check into 9.0, but we usually don't backpatch
> such things.
What do you mean by "such things"?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florian Pflug | 2011-07-25 17:57:40 | Re: Another issue with invalid XML values |
| Previous Message | Bernd Helmle | 2011-07-25 17:37:32 | Re: Another issue with invalid XML values |