Re: Move pg_attribute.attcompression to earlier in struct for reduced size?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date: 2021-05-27 11:58:33
Message-ID: CA+TgmoZ1jiHNcpjjUkxAhjxWFo83oMHjpeaCvyAh0K6bPbvzFg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 27, 2021 at 12:11 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> AFAIR, there are zero promises about how effective, or when effective,
> changes in SET STORAGE will be. And the number of complaints about
> that has also been zero. So I'm not sure why we need to do more for
> SET COMPRESSION. Especially since I'm unconvinced that recompressing
> everything just to recompress everything would *ever* be worthwhile.

I think it is good to have *some* way of ensuring that what you want
the system to do, it is actually doing. If we have not a single
operation in the system anywhere that can force recompression, someone
who actually cares will be left with no option but a dump and reload.
That is probably both a whole lot slower than something in the server
itself and also a pretty silly thing to have to tell people to do.

If it helps, I'd be perfectly fine with having this be an *optional*
behavior for CLUSTER or VACUUM FULL, depending on some switch. Or we
can devise another way for the user to make it happen. But we
shouldn't just be setting a policy that users are not allowed to care
whether their data is actually compressed using the compression method
they specified.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-05-27 12:08:46 Re: Bracket, brace, parenthesis
Previous Message Yura Sokolov 2021-05-27 11:54:11 Re: Add PortalDrop in exec_execute_message