From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Change format of FDW options used in \d* commands |
Date: | 2011-08-25 16:40:09 |
Message-ID: | CA+TgmoZ1GYZ8CKgQ_d4nxBdso73RLTV-aH66FF-ykr2mw4_kqg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2011/8/19 Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>:
> BTW, I noticed that pg_dump has same issue since 8.4, initial release of
> SQL/MED infrastructure. If a FDW option was defined on any FDW object
> with a name which contains one of special characters such as space and
> parentheses, pg_dump generates invalid OPTIONS clause such as "OPTIONS
> (separated name 'value')".
> ~~~~~~~~~~~~~~
> Perhaps this issue has been overlooked because dblink is practically the
> only use case of FDW option before 9.1. Since 9.1, users might get
> various FDW and some of those might use special characters in option
> name. ISTM that this fix should be back-patched, at least to 9.1.
> Please find attached patches for each STABLE branch.
Good catch, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-08-25 16:47:27 | A couple of issues with psql variable substitution |
Previous Message | Robert Haas | 2011-08-25 15:27:43 | Re: cheaper snapshots redux |