| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor comment improvement to create_foreignscan_plan |
| Date: | 2015-11-18 20:29:10 |
| Message-ID: | CA+TgmoZ03YMn_yDz0782TvDVvhMUB4D9OXXVngbzKff9Xm7GmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 17, 2015 at 9:29 PM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2015/11/18 2:57, Robert Haas wrote:
>> On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita
>> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>
>>> Oops, I've found another one. I think we should update a comment in
>>> postgresGetForeignPlan, too; add remote filtering expressions to the list
>>> of
>>> information needed to create a ForeignScan node.
>
>> Instead of saying "remote/local", how about saying "remote and local"
>> or just leaving it out altogether as in the attached?
>
> +1 for your patch.
OK, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2015-11-18 20:54:14 | Re: Freeze avoidance of very large table. |
| Previous Message | Pavel Stehule | 2015-11-18 20:24:19 | Re: proposal: multiple psql option -c |