Re: Custom table AMs need to include heapam.h because of BulkInsertState

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Custom table AMs need to include heapam.h because of BulkInsertState
Date: 2019-06-04 14:18:03
Message-ID: CA+TgmoZ-p_tBSj2n2cQW33esqnQhA5oj4944dUM3hVo-UyHFaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 1, 2019 at 3:09 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> I am fine to live with the dependency with vacuum.h as it is not that
> strange. However for BulkInsertState we get a hard dependency with a
> heap-related area and it seems to me that we had better move that part
> out of heapam.c, as we want a clear dependency cut with the heap AM
> for any new custom table AM.

Yeah, I noticed this, too. +1 for doing something about it. Not sure
exactly what is the best approach.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-06-04 15:27:31 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Previous Message Robert Haas 2019-06-04 13:05:17 Re: Avoiding hash join batch explosions with extreme skew and weird stats