Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

On Wed, Apr 27, 2016 at 9:53 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Let's add a GUC allow_oldstyle_functions with a default of off, and
>> make fetch_finfo_record() throw an ERROR in the infofunc == NULL case
>> unless allow_oldstyle_functions = on.
>
> This is not about "V0 calling convention is awful". It isn't, really,
> unless you need to deal with nulls. This is about "allowing the finfo
> record to be missing is error-prone". What about inventing a
> PG_FUNCTION_INFO_V0() macro, and then defining the new GUC as "must
> find a matching finfo record"? That would present less conversion
> work for people who still have V0-style functions (and I'm sure there
> are more than a few of them out there).

I'm not, but I don't have a problem with PG_FUNCTION_INFO_V0.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company