| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
| Subject: | Re: [PATCH] Remove unused argument in btree_xlog_split |
| Date: | 2017-04-05 16:05:48 |
| Message-ID: | CA+TgmoZ+foQmAYnFtDbmc3WBJmzFix=K2jPXbZov4SXvNRZ+pg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 31, 2017 at 10:10 AM, Aleksander Alekseev
<a(dot)alekseev(at)postgrespro(dot)ru> wrote:
> Turned out that there is an unused argument `isroot` in
> `btree_xlog_split` procedure. Suggested patch fixes it.
>
> This issue was discovered by Anastasia Lubennikova, coding is done by me.
Hmm. I don't see anything wrong with that, particularly, but it seems
we also don't need the distinction between XLOG_BTREE_SPLIT_L and
XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
a little further and do all of that together.
It looks like this is fallout from Heikki's 2014 commit
40dae7ec537c5619fc93ad602c62f37be786d161, which removed
log_incomplete_split().
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-04-05 16:06:43 | Re: PG_GETARG_GISTENTRY? |
| Previous Message | Tom Lane | 2017-04-05 16:04:00 | Re: partitioned tables and contrib/sepgsql |