From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: renaming pg_resetxlog to pg_resetwal has broken pg_upgrade. |
Date: | 2017-02-15 15:17:35 |
Message-ID: | CA+TgmoZ+52sO62b5fehia7c_r1HJOshe2JRHwjaOpb8N0vn_yA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Feb 14, 2017 at 5:13 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Feb 15, 2017 at 3:55 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>> I thought people would object to checking the version number in two
>> different places to make the same fundamental decision, and would want that
>> refactored somehow. But if you are OK with it, then I am.
>
> The binary versions are checked only once, which does not with change
> HEAD. With this patch it happens just earlier, which makes the most
> sense now that we have a condition depending on the version of what is
> installed.
Thanks, Michael! Committed.
I actually thought about this problem when I committed the original
patch but decided it ought to be OK because I didn't see why we'd be
running pg_resetxlog on the old cluster. I didn't think about the
fact that we might be running it with the -n option. Oops.
Thanks Jeff for the report.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-02-15 15:21:22 | Re: Documentation improvements for partitioning |
Previous Message | Peter Eisentraut | 2017-02-15 15:07:01 | Re: CREATE COLLATION IF NOT EXISTS |