Re: Extra functionality to createuser

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Christopher Browne <cbbrowne(at)gmail(dot)com>, Sameer Thakur <samthakur74(at)gmail(dot)com>, PostgreSQL Mailing Lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extra functionality to createuser
Date: 2013-12-11 12:53:28
Message-ID: CA+TgmoYzCqFDR21keo-7UQY2iikLDwHvot00epY8uQ-PZJCKOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 10, 2013 at 9:55 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Dec 10, 2013 at 12:20 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Sat, Dec 7, 2013 at 11:39 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>> On Fri, Dec 6, 2013 at 10:31 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>>>
>>>> How about only one role name per -g option, but allowing the -g option
>>>> to be repeated?
>>>
>>> I think that might simplify the problem and patch, but do you think
>>> it is okay to have inconsistency
>>> for usage of options between Create User statement and this utility?
>>
>> Yes. In general, command-line utilities use a very different syntax
>> for options-passing that SQL commands. Trying to make them consistent
>> feels unnecessary or perhaps even counterproductive. And the proposed
>> syntax is certainly a convention common to many other command-line
>> utilities, so I think it's fine.
>
> Okay, the new way for syntax suggested by Peter has simplified the problem.
> Please find the updated patch and docs for multiple -g options.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-12-11 13:02:30 Re: ANALYZE sampling is too good
Previous Message Andres Freund 2013-12-11 12:41:43 should we add a XLogRecPtr/LSN SQL type?