Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

On Tue, Nov 15, 2011 at 4:43 AM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> Part-2) Groundworks on objectaddress.c
> This patch adds necessary groundworks for Part-3 and Part-4.
> It adds ObjectPropertyType of objectaddress.c index-oid and cache-id
> for name lookup and attribute number of object name; these field is
> used to detect namespace conflict on object_exists_namespace() that
> shall be called on refactored ALTER SET SCHEMA/RENAME TO.
> It also reduce some arguments of check_object_ownership(), and allows
> to call this function without knowledge of ObjectType and text
> representation. It allows to check ownership using this function from
> the code path of AlterObjectNamespace_oid() that does not have (or
> need to look up catalog to obtain) ObjectType information.
> In addition, it adds regression test cases for ALTER SET SCHEMA/RENAME TO.

This part adds a new regression test to a parallel group with the
following comments:

# NB: temp.sql does a reconnect which transiently uses 2 connections,
# so keep this parallel group to at most 19 tests

...and this would be test #20. So we either need to move it
elsewhere, or move something else elsewhere. I'm tempted to add it to
this rather scrawny-looking group, unless someone sees a reason to do
otherwise:

test: privileges security_label collate

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company