Re: Add some regression tests for SEQUENCE

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Robins Tharakan <tharakan(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Subject: Re: Add some regression tests for SEQUENCE
Date: 2013-07-03 15:13:00
Message-ID: CA+TgmoYz-AFWqNo0WMwF_Mc+JuQd8fXo-vALNd+hsrEFEoy8MA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 7, 2013 at 6:40 PM, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
> Have provided an updated patch as per Fabien's recent response on Commitfest
> site.
> Any and all feedback is appreciated.

I think you should rename the roles used here to regress_rol_seq1 etc.
to match the CREATE OPERATOR patch.

And you need to update the expected output.

Setting this one to "Waiting on Author".

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-07-03 15:14:18 Re: possible/feasible to specify field and value in error msg?
Previous Message Ian Lawrence Barwick 2013-07-03 15:12:11 (trivial patch) remove superfluous semicolons from pg_dump