Re: show Heap Fetches in EXPLAIN for index-only scans

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: show Heap Fetches in EXPLAIN for index-only scans
Date: 2012-01-13 16:08:16
Message-ID: CA+TgmoYxhDn4RDXkPAEWG6Diy7jB2D0-i+cP41WGhRyew5cTCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 13, 2012 at 10:41 AM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> On 13 January 2012 15:31, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Jan 13, 2012 at 10:29 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>> Would also be good to have counter sin pg_stat_* for this, since you'd
>>> usually want to look at this kind of data over time as well. In your
>>> plans? ;)
>>
>> Not really.  I don't have a clear enough idea about what that should
>> look like, and I expect a vigorous debate over the distributed cost of
>> another counter.  But I'm happy to have someone who feels more
>> strongly about it than I do take up the cause.
>
> Maybe the the ioss_HeapFetches field should be a uint32? That's all
> it's going to be on some platforms anyway.

I originally had it that way, but then it didn't match what
ExplainPropertyLong() was looking for. I didn't think it was worth
further complicating explain.c for this...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-01-13 16:13:46 Re: Disabled features on Hot Standby
Previous Message Kevin Grittner 2012-01-13 16:00:32 Re: TG_DEPTH patch v1