| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, hlinnaka <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Date: | 2015-05-14 21:46:37 |
| Message-ID: | CA+TgmoYvZ=zoevdcpHFEGB8LXf6a6e9V5YfvZVMmgzH=bz-dSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, May 14, 2015 at 12:59 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> I'm not sure I understand this issue in detail, but why would using
>> rmtree() on something you expect to be a symlink ever be a good idea?
>> It seems like if things are the way you expect them to be, it has no
>> benefit, but if they are different from what you expect, you might
>> blow away a ton of important data.
>>
>> Maybe I am just confused.
>
> The suggestion is to get rid of using rmtree. Instead, if we find a
> non-symlink in pg_tblspc we'll make the user clean it up before we can
> continue. So your instinct is in tune with my suggestion.
Right. Maybe I should have just said "+1".
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2015-05-15 00:10:48 | pgsql: Add pg_settings.pending_restart column |
| Previous Message | Bruce Momjian | 2015-05-14 21:38:37 | pgsql: doc: list bigint as mapping to int8 and int64 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2015-05-14 21:54:17 | Re: Triaging the remaining open commitfest items |
| Previous Message | Tom Lane | 2015-05-14 21:37:07 | Re: Triaging the remaining open commitfest items |