| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Maksim Milyutin <milyutinma(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Proposal: Local indexes for partitioned table |
| Date: | 2017-11-14 20:51:40 |
| Message-ID: | CA+TgmoYuqTqHLfOkZvdyU93nWC9QYkp=a2_P+FMzvhjWkDfX-g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 14, 2017 at 1:43 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> I don't see any comments from you or Tom about patch 0001, which was
> simple refactoring and not much to complain about.
We both commented that getting rid of copy_partition_data could
introduce memory leaks.
> Perhaps there is some confusion about the numbering?
I don't think so.
> I see that Alvaro had taken your comments on memory contexts into
> account in his later patch.
Which later patch? It seems like any changes meant to mitigate the
problems with removing copy_partition_data ought to be folded into the
patch that removes copy_partition_data, rather than being in some
other patch later in the series.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-11-14 21:24:39 | Re: [HACKERS] Parallel Hash take II |
| Previous Message | Ryan Murphy | 2017-11-14 20:40:21 | Re: PGLister: how to subscribe to digests instead of getting every email? |