| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "dipesh(dot)pandit(at)gmail(dot)com" <dipesh(dot)pandit(at)gmail(dot)com>, "jeevan(dot)ladhe(at)enterprisedb(dot)com" <jeevan(dot)ladhe(at)enterprisedb(dot)com>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "hannuk(at)google(dot)com" <hannuk(at)google(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: .ready and .done files considered harmful |
| Date: | 2021-09-07 18:30:23 |
| Message-ID: | CA+TgmoYupCw+cORkcM0Ut2fsGLd5srnRYmebjr2N+jYzbUX1-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 7, 2021 at 2:13 PM Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
> Right. The latest patch for that approach [0] does just that. In
> fact, I think timeline files are the only files for which we need to
> force an immediate directory scan in the multiple-files-per-scan
> approach. For the keep-trying-the-next-file approach, we have to
> force a directory scan for anything but a regular WAL file that is
> ahead of our archiver state.
Yeah, that makes sense.
> Yeah, I would agree that the approaches basically converge into some
> form of "do fewer directory scans."
I guess we still have to pick one or the other, but I don't really
know how to do that, since both methods seem to be relatively fine,
and the scenarios where one is better than the other all feel a little
bit contrived. I guess if no clear consensus emerges in the next week
or so, I'll just pick one and commit it. Not quite sure yet how I'll
do the picking, but we seem to all agree that something is better than
nothing, so hopefully nobody will be too sad if I make an arbitrary
decision. And if some clear agreement emerges before then, even
better.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-07 18:31:33 | Re: EXPLAIN(VERBOSE) to CTE with SEARCH BREADTH FIRST fails |
| Previous Message | Bossart, Nathan | 2021-09-07 18:13:39 | Re: .ready and .done files considered harmful |