| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Timothy Garnett <tgarnett(at)panjiva(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Re: BUG #12990: Missing pg_multixact/members files (appears to have wrapped, then truncated) |
| Date: | 2015-05-07 15:04:11 |
| Message-ID: | CA+TgmoYtFwG2n61WAiSKcgEqFSXWkUr6oSyzeGD_KtUn7CvNKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, May 7, 2015 at 12:23 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> This patch will change it anyway, but I noticed that oldestOffset's
> computation to find the start of the segment seems wrong in master, I
> think it should be like this, no?
>
> @@ -2495,7 +2495,7 @@ DetermineSafeOldestOffset(MultiXactId oldestMXact)
> */
> oldestOffset = find_multixact_start(oldestMXact);
> /* move back to start of the corresponding segment */
> - oldestOffset -= oldestOffset / MULTIXACT_MEMBERS_PER_PAGE *
> SLRU_PAGES_PER_SEGMENT;
> + oldestOffset -= oldestOffset % (MULTIXACT_MEMBERS_PER_PAGE *
> SLRU_PAGES_PER_SEGMENT);
>
> LWLockAcquire(MultiXactGenLock, LW_EXCLUSIVE);
> /* always leave one segment before the wraparound point */
This should be committed and back-patched separately, I think. I'll
go do that now.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2015-05-07 15:05:15 | Re: Re: BUG #12990: Missing pg_multixact/members files (appears to have wrapped, then truncated) |
| Previous Message | Bruce Momjian | 2015-05-07 14:40:29 | Re: BUG #13220: make uninstall removes man pages not belonging to PostgreSQL |