On Thu, Feb 15, 2024 at 3:05 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> Kindly have a look at the attached version.
IMHO, 0001 looks fine, except probably the comment could be phrased a
bit more nicely. That can be left for whoever commits this to
wordsmith. Michael, what are your plans?
0002 seems like a reasonable approach, but there's a hunk in the wrong
patch: 0004 modifies pg_combinebackup's check_control_files to use
get_dir_controlfile() rather than git_controlfile(), but it looks to
me like that should be part of 0002.
--
Robert Haas
EDB: http://www.enterprisedb.com