From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding) |
Date: | 2014-09-29 15:06:26 |
Message-ID: | CA+TgmoYr=t1eEqm0VWsEKmNLDuw-w0w2j3JL3JBViOz+BhML0g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Sep 29, 2014 at 9:03 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> - except that changes are returned as <type>bytea</type>.
>> + except that changes are returned as <type>bytea</type> and that it
>> can
>> + be used on slots using output plugins that only support binary
>> output.
>
> Imo that's pretty much implied because it references the !binary
> version. But I guess it doesn't hurt to be explicit. How about:
> " ... on output plugins using any form of output, including binary."?
I think you should just leave it alone. There's no problem with what
it says there right now. It goes without saying that if the plugin
can only return bytea, then you have to use the bytea-returning
function to get it. If it's not clear that such plugins might exist,
that needs to be clarified better elsewhere, not here.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-09-29 15:07:16 | Re: [v9.5] Custom Plan API |
Previous Message | Robert Haas | 2014-09-29 15:02:49 | Re: [REVIEW] Re: Compression of full-page-writes |