Re: Invalid pg_upgrade error message during live check

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Invalid pg_upgrade error message during live check
Date: 2018-01-08 15:43:00
Message-ID: CA+TgmoYqmfeuVkWCOSB=Rrt9ctnLDFEbbkvH08NzD-vAbMhq5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 5, 2018 at 9:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Fri, Jan 5, 2018 at 04:58:39PM -0500, Bruce Momjian wrote:
>> Pg_upgrade is able to run in --check mode when the old server is still
>> running. Unfortunately, all supported versions of pg_upgrade generate
>> an incorrect (but harmless) "failure" message when doing this:
>
> Based on recent discussions, I am thinking we would just fix this in PG
> 10 and HEAD and leave the harmless error message in the other branches,
> right?

Hmm, not sure why you say that. If the message is buggy and the fix
isn't too risky, might as well fix it all the way back.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2018-01-08 15:44:11 Re: pgsql: Implement channel binding tls-server-end-point for SCRAM
Previous Message Tom Lane 2018-01-08 15:23:07 Re: PL/Python SD dict wiped?