| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DROP OWNED BY is broken on master branch. |
| Date: | 2022-09-27 14:04:14 |
| Message-ID: | CA+TgmoYpsbd7PCxPDiiq-9eh-x1j7f27iqJ0tZpwDXFOCB7Y6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 27, 2022 at 2:53 AM Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> wrote:
> Yes, I was also thinking to avoid the duplicate logic but couldn't found
> a way. I did the quick testing with the patch, and reported test is working
> fine. But "make check" is failing with few failures.
Oh, woops. There was a dumb mistake in that version -- it was testing
sdepForm->dbid == SHARED_DEPENDENCY_OWNER, which is nonsense, instead
of sdepForm->dbid == MyDatabaseId. Here's a fixed version.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-bug-in-DROP-OWNED-BY.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2022-09-27 14:25:14 | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
| Previous Message | Hamid Akhtar | 2022-09-27 13:54:04 | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |