| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: GinPageIs* don't actually return a boolean |
| Date: | 2016-03-18 14:57:49 |
| Message-ID: | CA+TgmoYoHYpN919mcRH36NKVzuSiYxbN_agrN=_JFPhVOZDqRg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 10, 2016 at 11:00 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-03-11 04:50:45 +0100, Michael Paquier wrote:
>> On Thu, Mar 10, 2016 at 11:40 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> > We need to decide what to do about this. I disagree with Peter: I
>> > think that regardless of stdbool, what we've got right now is sloppy
>> > coding - bad style if nothing else. Furthermore, I think that while C
>> > lets you use any non-zero value to represent true, our bool type is
>> > supposed to contain only one of those two values. Therefore, I think
>> > we should commit the full patch, back-patch it as far as somebody has
>> > the energy for, and move on. But regardless, this patch can't keep
>> > sitting in the CommitFest - we either have to take it or reject it,
>> > and soon.
>
> I plan to commit something like this, unless there's very loud protest
> from Peter's side.
So, can we get on with that, then?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-03-18 15:01:04 | Re: RFC: replace pg_stat_activity.waiting with something more descriptive |
| Previous Message | Robert Haas | 2016-03-18 14:56:39 | Re: pgbench - allow backslash-continuations in custom scripts |