| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com> |
| Cc: | Dimitri Fontaine <dimitri(at)citusdata(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Prepare Transaction support for ON COMMIT DROP temporary tables |
| Date: | 2019-01-18 15:39:46 |
| Message-ID: | CA+TgmoYnrCqfreyOwSzL-ei+qMapTwAMpQNwpmbp+=Wq78kQCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 18, 2019 at 4:50 AM Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com> wrote:
> Isn't that what happens already? PrepareTransaction() calls
> PreCommit_on_commit_actions() from what I can tell.
Huh. Well, in that case, I'm not sure I understand we really need to
do beyond removing the error checks for the case where all tables are
on-commit-drop.
It could be useful to do something about the issue with pg_temp
creation that Tom linked to in the other thread. But even if you
didn't do that, it'd be pretty easy to work around this in application
code -- just issue a dummy CREATE TEMP TABLE .. ON COMMIT DROP
statement the first time you use a connection, so that the temp schema
definitely exists. So I'm not sure I'd view that as a blocker for
this patch, even though it's kind of a sucky limitation.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-01-18 16:35:56 | Re: Tid scan improvements |
| Previous Message | Andreas Karlsson | 2019-01-18 15:18:03 | Re: Feature: temporary materialized views |