Re: row_to_json(), NULL values, and AS

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neil(dot)conway(at)gmail(dot)com>, Postgres-Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: row_to_json(), NULL values, and AS
Date: 2018-06-19 14:34:49
Message-ID: CA+TgmoYnWZVnDJofLZ1x+rPN=R=362tUfUacnyMymqk0R3Mx=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Jun 15, 2018 at 10:53 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I'm a bit hesitant to muck with this behavior, given that it's stood
> for ~20 years. However, if we did want to touch it, maybe the right
> thing would be to give up the absolutist position that f(x) and x.f
> are exactly interchangeable. We could say instead that we prefer the
> function interpretation if function syntax is used, and the column
> interpretation if column syntax is used. I don't know how likely
> that is to break existing apps ... perhaps not very, but I wouldn't
> risk back-patching it in any case.

For the record, I fear that this change (committed as
b97a3465d73bfc2a9f5bcf5def1983dbaa0a26f8) is going to break more
things than have been foreseen in this thread. I do not have a
specific theory about how that's going to happen, just vague unease.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2018-06-19 15:11:30 Re: row_to_json(), NULL values, and AS
Previous Message Tom Lane 2018-06-19 14:23:36 Re: BUG #15247: At 'ALTER TABLE ADD COLUMN fast default' , Set attmissingval to NULL in the pg_attribute, query fail

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-06-19 14:40:16 Re: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows
Previous Message Robert Haas 2018-06-19 14:28:55 Re: Internal error XX000 with enable_partition_pruning=on, pg 11 beta1 on Debian