From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Phil Eaton <phil(at)eatonphil(dot)com> |
Cc: | fabriziomello(at)gmail(dot)com, Roberto Mello <roberto(dot)mello(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Add minimal C example and SQL registration example for custom table access methods. |
Date: | 2024-05-14 20:07:09 |
Message-ID: | CA+TgmoYnSuSydAHS-EQEFDcdyQUty9sWv3ejPHcEzjFRQPqiMg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs pgsql-hackers |
On Tue, May 14, 2024 at 3:02 PM Phil Eaton <phil(at)eatonphil(dot)com> wrote:
> > I took a look at this patch and I don't think this is a very good
> > idea,
>
> No problem! I've dropped the v2 code additions and stuck with the v1
> attempt plus feedback.
That looks more reasonable. I'd like to quibble with this text:
+. Here is an example of how to register an extension that provides a
+ table access method handler:
I think this should say something more like "Here is how an extension
SQL script might create a table access method handler". I'm not sure
if we have a standard term in our documentation that should be used
instead of "extension SQL script"; perhaps look for similar examples,
or the documentation of extensions themselves, and copy the wording.
Shouldn't "mem_tableam_handler" be "my_tableam_handler"?
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | jian he | 2024-05-15 09:18:23 | Re: Add small detail to RAISE statement descripton |
Previous Message | Phil Eaton | 2024-05-14 19:02:03 | Re: Add minimal C example and SQL registration example for custom table access methods. |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2024-05-14 20:09:39 | Re: BitmapHeapScan streaming read user and prelim refactoring |
Previous Message | Alvaro Herrera | 2024-05-14 20:05:35 | Re: BitmapHeapScan streaming read user and prelim refactoring |