| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
| Date: | 2021-09-29 15:20:29 |
| Message-ID: | CA+TgmoYnRZEaYQP3L=wNRbYYnAYK=Sff54d5ueiZZcgL+rKeAA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Sep 21, 2021 at 6:48 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Document XLOG_INCLUDE_XID a little better
>
> I noticed that commit 0bead9af484c left this flag undocumented in
> XLogSetRecordFlags, which led me to discover that the flag doesn't
> actually do what the one comment on it said it does. Improve the
> situation by adding some more comments.
>
> Backpatch to 14, where the aforementioned commit appears.
I'm not sure that saying something is a "hack" is really all that
useful as documentation.
But more to the point, I think this hack is ugly and needs to be
replaced with something less hacky.
Amit?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-09-29 21:24:26 | pgsql: psql: Add various tests |
| Previous Message | Alvaro Herrera | 2021-09-29 14:42:23 | pgsql: Fix WAL replay in presence of an incomplete record |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-29 15:59:14 | Re: Some thoughts about the TAP tests' wait_for_catchup() |
| Previous Message | Alvaro Herrera | 2021-09-29 14:48:11 | Re: prevent immature WAL streaming |