| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: Logical slots not mentioned in CREATE_REPLICATION_SLOT for replication protocol docs |
| Date: | 2014-05-29 20:31:22 |
| Message-ID: | CA+TgmoYmKZqKhkRs7LzFM9qKYZ=unnk-tuPhOk3vd_GWXDqaxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 22, 2014 at 12:18 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, May 22, 2014 at 12:44 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> Hi all,
>>
>> As written in subject, replication protocol documentation lacks
>> details about logical slots in CREATE_REPLICATION_SLOT command:
>> http://www.postgresql.org/docs/devel/static/protocol-replication.html
>> Attached is a patch correcting that.
> An additional thing I noticed: START_REPLICATION does not mention that
> it is possible to specify options for the output plugin. All the fixes
> are included in the patch attached.
Thanks, this looks good. But shouldn't the bit about output plugin
options mention say something like:
( option_name option_argument [, ...] )
...instead of just:
( option [, ...] )
?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-05-29 20:34:00 | Re: CHECK_FOR_INTERRUPTS in spgdoinsert() isn't helpful |
| Previous Message | Tom Lane | 2014-05-29 20:25:52 | CHECK_FOR_INTERRUPTS in spgdoinsert() isn't helpful |