| From: | Robert Haas <robertmhaas(at)gmail(dot)com> | 
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> | 
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> | 
| Subject: | Re: shared memory message queues | 
| Date: | 2013-12-17 16:51:47 | 
| Message-ID: | CA+TgmoYkgyniDyzSznF2XgZE0inztTq93P2NNrAUhUP+cfWcxw@mail.gmail.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
On Sat, Dec 7, 2013 at 3:02 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Leaving it as separate calls sounds good to me as well - but like you I
>> don't like on_user_exit() that much. Not sure if I can up with something
>> really good...
>> on_shmem_exit_phase() or at_shmem_exit_phase() if we go for a function
>> allowing to specify phases, and just before_shmem_exit() for the "user
>> level" things?
>
> Hmm, before_shmem_exit() and on_shmem_exit() doesn't sound bad.
So here's an updated patch that takes that approach.  It has a
substantially reduced footprint compared to the previous version, and
probably less chance of breaking third-party code. I also incorporated
your suggestion of renaming on_dsm_detach_cancel to
cancel_on_dsm_detach.
Unless anyone wants to further kibitz the naming here, I'm thinking
this part is ready to commit.  I'll rebase and update the remaining
patches after that's done.
-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size | 
|---|---|---|
| on-dsm-detach-v3.patch | text/x-patch | 15.4 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2013-12-17 16:54:43 | Re: ANALYZE sampling is too good | 
| Previous Message | Pavel Stehule | 2013-12-17 16:49:20 | Re: patch: make_timestamp function |