| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: gaussian distribution pgbench -- splits v4 |
| Date: | 2014-07-30 17:24:59 |
| Message-ID: | CA+TgmoYex+vRuGUUSTA5UmKLTvj5yuyDesto5vmo8Rh0=te1xg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 29, 2014 at 4:41 AM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>> Attached B patch does turn incorrect setrandom syntax into errors instead
>> of ignoring extra parameters.
>>
>> First A patch is repeated to help commitfest references.
>
> Oops, I applied the change on the wrong part:-(
>
> Here is the change on part A which checks setrandom syntax, and B for
> completeness.
I've committed the changes to pgbench.c and the documentation changes
with some further wordsmithing. I don't think including the other
changes in patch A is a good idea, nor am I in favor of patch B. But
thanks for your and Kondo-san's hard work on this; I think this will
be quite useful.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-07-30 17:27:24 | commitfest status |
| Previous Message | Alexander Korotkov | 2014-07-30 16:42:02 | Re: Distance from point to box |