Re: [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

On Fri, May 19, 2017 at 12:51 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, May 19, 2017 at 1:16 PM, Higuchi, Daisuke
> <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com> wrote:
>> The reason of this problem is that sending 'show transaction_read_only' is failed.
>> 'show' must be in uppercase letters because the streaming replication protocol only accepts capital letters.
>> In psql and libpq applications that do not use the streaming replication protocol, this error does not occur.
>>
>> The attached patch fixes this. This patch changes 'show transaction_read_only' to 'SHOW transaction_read_only'.
>
> if (!PQsendQuery(conn,
> - "show transaction_read_only"))
> + "SHOW transaction_read_only"))
> Or perhaps the replication command parser could be made more flexible
> with lower-case characters for replication commands?

Maybe, but that sounds a lot more likely to inflict collateral damage
of some kind than the originally-proposed fix, so I've committed that
fix instead.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company