From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_upgrade broken by xlog numbering |
Date: | 2012-06-25 17:16:23 |
Message-ID: | CA+TgmoYdjXVv8U+=6Ny2nHWt1huLf=gkWJDFaEF6+xQ9=wC54g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jun 25, 2012 at 8:11 AM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> On HEAD at the moment, `make check-world` is failing on a 32-bit Linux
> build:
This appears to be because of the following hunk from commit
dfda6ebaec6763090fb78b458a979b558c50b39b:
@@ -558,10 +536,10 @@ PrintControlValues(bool guessed)
snprintf(sysident_str, sizeof(sysident_str), UINT64_FORMAT,
ControlFile.system_identifier);
- printf(_("First log file ID after reset: %u\n"),
- newXlogId);
- printf(_("First log file segment after reset: %u\n"),
- newXlogSeg);
+ XLogFileName(fname, ControlFile.checkPointCopy.ThisTimeLineID, newXlogSe
+
+ printf(_("First log segment after reset: %s\n"),
+ fname);
printf(_("pg_control version number: %u\n"),
ControlFile.pg_control_version);
printf(_("Catalog version number: %u\n"),
Evidently, Heikki failed to realize that pg_upgrade gets the control
data information by parsing the output of pg_controldata.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2012-06-25 17:20:26 | Re: [PATCH 04/16] Add embedded list interface (header only) |
Previous Message | Robert Haas | 2012-06-25 17:12:54 | Re: [COMMITTERS] pgsql: Remove sanity test in XRecOffIsValid. |