Re: Tighten error control for OpenTransientFile/CloseTransientFile

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Tighten error control for OpenTransientFile/CloseTransientFile
Date: 2019-03-06 21:09:02
Message-ID: CA+TgmoYb00PYSVQc5L-DGjq91DXfimCevr0_mL8fcbbNpe58Kg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 1, 2019 at 5:06 PM Joe Conway <mail(at)joeconway(dot)com> wrote:
> Seems like it would be better to modify the arguments to
> CloseTransientFile() to include the filename being closed, errorlevel,
> and fail_on_error or something similar. Then all the repeated ereport
> stanzas could be eliminated.

Hmm. I'm not sure that really saves much in terms of notation, and
it's less flexible.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-03-06 21:37:11 Re: Making all nbtree entries unique by having heap TIDs participate in comparisons
Previous Message Andres Freund 2019-03-06 20:41:04 Binary upgrade from <12 to 12 creates toast table for partitioned tables