Re: [PATCH] Assert that the correct locks are held when calling PageGetLSN()

On Thu, Aug 31, 2017 at 2:53 PM, Jacob Champion <pchampion(at)pivotal(dot)io> wrote:
> While working on checksum support for GPDB, we noticed that several
> callers of PageGetLSN() didn't follow the correct locking procedure.
> To try to help ferret out present and future mistakes, we added an
> assertion to PageGetLSN() that checks whether those locks were being
> held correctly. This patch is a first-draft attempt to port that
> assertion back up to postgres master, based on work by Asim Praveen,
> Ashwin Agrawal, and myself.
>
> The patch is really two pieces: add the assertion, and fix the callers
> that would trip it. The latter part is still in progress, because I'm
> running into some places where I'm not sure what the correct way
> forward is.
>
> (I'm a newbie to this list and this code base, so please don't
> hesitate to correct me on anything, whether that's code- or
> culture-related!)

It's a good idea to add patches to commitfest.postgresql.org

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company