| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: BitmapHeapScan streaming read user and prelim refactoring |
| Date: | 2024-03-14 13:20:56 |
| Message-ID: | CA+TgmoY_PpJP9BZpnC0yXsxO98H3G9BZzf_8QPyhn7vhwTRCTA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 14, 2024 at 9:00 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> The portal code is pretty explicit about it, the ExecutorRun() call in
> PortalRunSelect() looks like this:
>
> PushActiveSnapshot(queryDesc->snapshot);
> ExecutorRun(queryDesc, direction, (uint64) count,
> portal->run_once);
> nprocessed = queryDesc->estate->es_processed;
> PopActiveSnapshot();
>
> I looked at all the callers of ExecutorRun(), and they all have the
> active snapshot equal to queryDesc->snapshot, either because they called
> CreateQueryDesc() with the active snapshot before ExecutorRun(), or they
> set the active snapshot like above.
Well, maybe there's a bunch of code cleanup possible, then.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Treat | 2024-03-14 13:21:18 | Re: small_cleanups around login event triggers |
| Previous Message | Robert Haas | 2024-03-14 13:15:56 | Re: [PATCH] LockAcquireExtended improvement |