Re: ALTER TABLE with ADD COLUMN and ADD PRIMARY KEY USING INDEX throws spurious "column contains null values"

On Wed, Apr 17, 2019 at 11:55 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> * I'm not sure whether we want to try to back-patch this, or how
> far it should go. The misbehavior has been there a long time
> (at least back to 8.4, I didn't check further); so the lack of
> previous reports means people seldom try to do it. That may
> indicate that it's not worth taking any risks of new bugs to
> squash this one. (Also, I suspect that it might take a lot of
> work to port this to before v10, because there are comments
> suggesting that this code worked a good bit differently before.)
> I do think we should shove this into v12 though.

Shoving it into v12 but not back-patching seems like a reasonable
compromise, although I have not reviewed the patch or tried to figure
out how risky it is.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company