From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Refactor xlog.c #1 - startup.c |
Date: | 2011-11-02 13:14:45 |
Message-ID: | CA+TgmoYZkShm_sG6=4MPC50XhLZgzTXq-d1oYCnNDQtj+iwWTg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 2, 2011 at 4:44 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Patch removes stuff related to "startup process" and creates files
> under src/$DIR/postmaster for this code.
>
> This makes startup process look more like bgwriter, walwriter etc..
In general, +1.
But I don't think we want duplicate function prototypes for the same
functions, so -1 for this hunk:
+ /* in xlog.c */
+ extern void WakeupRecovery(void);
+ extern void StartupXLOG(void);
The existing prototypes in xlog.h seem like they should be just fine.
IsPromoteTriggered could be simplified to just "return
promote_triggered;"; you don't need to branch.
I think one thing that would be worth considering in terms of future
refactoring is to split up the gigantic StartupXLOG() function in some
fashion.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2011-11-02 13:29:33 | Re: Thoughts on "SELECT * EXCLUDING (...) FROM ..."? |
Previous Message | Stephen Frost | 2011-11-02 12:32:23 | Re: Thoughts on "SELECT * EXCLUDING (...) FROM ..."? |