Re: PQputCopyEnd doesn't adhere to its API contract

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PQputCopyEnd doesn't adhere to its API contract
Date: 2014-05-08 19:03:49
Message-ID: CA+TgmoYZiZ+pf6yCHMVt2X2nXotLCQnrpVd5XG4S4CRnwDny6g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 8, 2014 at 1:51 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> OK. It still seems to me that there's a doc fix needed here, if
>> nothing else. The documentation for PQputCopyEnd() clearly implies
>> that if you get a return value of 1, the message is sent, and that's
>> just not true.
>
> That's fair.

Something like the attached?

I don't really know what to say about 0, since it's never actually
returned, so I left that out. But I'm up for suggestions.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
libpq-putcopyend-doc.patch text/x-patch 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-05-08 19:10:53 Re: [v9.5] Custom Plan API
Previous Message Alvaro Herrera 2014-05-08 18:48:04 Re: Sending out a request for more buildfarm animals?