| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Changeset Extraction v7.6.1 |
| Date: | 2014-02-19 18:01:56 |
| Message-ID: | CA+TgmoYXXvuch8yJkwOSakgs+Oiov7oadAomy1NUCZAXQyg7Lg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 16, 2014 at 12:12 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2014-02-15 17:29:04 -0500, Robert Haas wrote:
>> On Fri, Feb 14, 2014 at 4:55 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> > [ new patches ]
>>
>> 0001 already needs minor
>>
>> + * copied stuff from tuptoaster.c. Perhaps there should be toast_internal.h?
>>
>> Yes, please. If you can submit a separate patch creating this file
>> and relocating this stuff there, I will commit it.
>
> I started to work on that, but I am not sure we actually need it
> anymore. tuptoaster.h isn't included in that many places, so perhaps we
> should just add it there?
That seems fine to me.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-02-19 18:07:11 | Re: Changeset Extraction v7.6.1 |
| Previous Message | Alvaro Herrera | 2014-02-19 18:01:04 | Re: Fwd: patch: make_timestamp function |