Re: pgsql: Perform less setup work for AFTER triggers at transaction start.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Perform less setup work for AFTER triggers at transaction start.
Date: 2014-10-23 22:59:21
Message-ID: CA+TgmoYX6PRy33uesTn0K8v8CHcUuWtOF8G_qt6gwaWXpKu65g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Oct 23, 2014 at 1:57 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>> Perform less setup work for AFTER triggers at transaction start.
>
> Perhaps I'm confused, but doesn't AfterTriggerEnlargeQueryState()
> need to ensure there are at least query_depth + 1 entries in the
> arrays? Not just query_depth?

Hmm, I think you're right. Like this?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
query-depth-oops.patch text/x-patch 925 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2014-10-23 23:53:53 pgsql: Update README.tuplock
Previous Message Tom Lane 2014-10-23 19:59:47 pgsql: In type_sanity, check I/O functions of built-in types are not vo